From 8b16f6aeb19673c89ad5cc561ef9a2d5c6ac81fb Mon Sep 17 00:00:00 2001 From: Sean Hammond Date: Mon, 30 Apr 2012 17:59:44 +0200 Subject: [PATCH] [#2304] Make follow button js a bit more efficient --- ckan/public/scripts/application.js | 30 ++++++++++++++++-------------- 1 file changed, 16 insertions(+), 14 deletions(-) diff --git a/ckan/public/scripts/application.js b/ckan/public/scripts/application.js index 5988fe0f432..77b298181f2 100644 --- a/ckan/public/scripts/application.js +++ b/ckan/public/scripts/application.js @@ -1418,26 +1418,28 @@ CKAN.Utils = function($, my) { }; my.setupUserFollowButton = function() { - if ($('#user_follow_button').attr('state') == 'follow') { - $('#user_follow_button').off("click", userUnfollowClicked); - $('#user_follow_button').html('Follow'); - $('#user_follow_button').on("click", userFollowClicked); + var userFollowButton = $('#user_follow_button'); + if (userFollowButton.attr('state') == 'follow') { + userFollowButton.off("click", userUnfollowClicked); + userFollowButton.html('Follow'); + userFollowButton.on("click", userFollowClicked); } else { - $('#user_follow_button').off("click", userFollowClicked); - $('#user_follow_button').html('Unfollow'); - $('#user_follow_button').on("click", userUnfollowClicked); + userFollowButton.off("click", userFollowClicked); + userFollowButton.html('Unfollow'); + userFollowButton.on("click", userUnfollowClicked); } }; my.setupDatasetFollowButton = function() { - if ($('#dataset_follow_button').attr('state') == 'follow') { - $('#dataset_follow_button').off("click", datasetUnfollowClicked); - $('#dataset_follow_button').html('Follow'); - $('#dataset_follow_button').on("click", datasetFollowClicked); + var datasetFollowButton = $('#dataset_follow_button'); + if (datasetFollowButton.attr('state') == 'follow') { + datasetFollowButton.off("click", datasetUnfollowClicked); + datasetFollowButton.html('Follow'); + datasetFollowButton.on("click", datasetFollowClicked); } else { - $('#dataset_follow_button').off("click", datasetFollowClicked); - $('#dataset_follow_button').html('Unfollow'); - $('#dataset_follow_button').on("click", datasetUnfollowClicked); + datasetFollowButton.off("click", datasetFollowClicked); + datasetFollowButton.html('Unfollow'); + datasetFollowButton.on("click", datasetUnfollowClicked); } };