From c06534a4a14f0beeeb33db5a05237c9fcda8182e Mon Sep 17 00:00:00 2001 From: John Glover Date: Fri, 21 Jun 2013 10:45:20 +0200 Subject: [PATCH] [#1033] Fix validation in term_translation_update_many. Now checks that data is present and that it is a list. --- ckan/logic/action/update.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/ckan/logic/action/update.py b/ckan/logic/action/update.py index ad90f86fab5..630ed7ba17e 100644 --- a/ckan/logic/action/update.py +++ b/ckan/logic/action/update.py @@ -764,11 +764,10 @@ def term_translation_update_many(context, data_dict): ''' model = context['model'] - - if not data_dict.get('data') and isinstance(data_dict, list): + if not (data_dict.get('data') and isinstance(data_dict.get('data'), list)): raise ValidationError( - {'error': - 'term_translation_update_many needs to have a list of dicts in field data'} + {'error': ['term_translation_update_many needs to have a ' + 'list of dicts in field data']} ) context['defer_commit'] = True