From 12e9f111b92f5d9c8686e6d589439aa6ccdf0f6a Mon Sep 17 00:00:00 2001 From: Alex Sadleir Date: Wed, 22 Jul 2015 12:04:58 +1000 Subject: [PATCH] Handle special characters in column names to fix recline view Some special characters/unicode characters are causing recline view sanitization for HTML to fail with a JS error: ``` "bootstrap.js:3 Uncaught Error: Syntax error, unrecognized expression:" ``` Fixes #2490 by catching JS exceptions --- ckanext/reclineview/theme/public/vendor/recline/recline.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ckanext/reclineview/theme/public/vendor/recline/recline.js b/ckanext/reclineview/theme/public/vendor/recline/recline.js index 42be8731bcc..d2d9f7c6d77 100755 --- a/ckanext/reclineview/theme/public/vendor/recline/recline.js +++ b/ckanext/reclineview/theme/public/vendor/recline/recline.js @@ -3222,7 +3222,12 @@ my.SlickGrid = Backbone.View.extend({ } function sanitizeFieldName(name) { - var sanitized = $(name).text(); + var sanitized; + try{ + sanitized = $(name).text(); + } catch(e) { + sanitized = ''; + } return (name !== sanitized && sanitized !== '') ? sanitized : name; }