Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite to organization has hard-coded email text #1527

Closed
rossjones opened this issue Feb 19, 2014 · 3 comments

Comments

Projects
None yet
6 participants
@rossjones
Copy link
Collaborator

commented Feb 19, 2014

Would be useful if the email text in get_invite_body() (from mailer.py) loaded a template with the text so that extensions can override it. When working around #1506 it is likely that the email template will need to be changed, and/or other users might want to change the text of the email.

@nigelbabu

This comment has been minimized.

Copy link
Contributor

commented Feb 21, 2014

Hi @rossjones, at the dev meeting, we felt this was a good idea. The thing to consider is translations and having the subject changeable as well.

@amercader amercader added this to the CKAN 2.4 milestone Oct 22, 2014

amercader added a commit that referenced this issue Jun 12, 2015

[#1527] Make emails customizable
Read the reset password and invite user emails body from text templates
(which are magically translated!) and the subjects from config options.

amercader added a commit that referenced this issue Jun 12, 2015

amercader added a commit that referenced this issue Jun 12, 2015

amercader added a commit that referenced this issue Jun 12, 2015

amercader added a commit that referenced this issue Jun 15, 2015

[#1527] Add information about the org/group and role to the invite email
The current invite email doesn't really give you much information about
what you are actually signing for. This adds the organization title and
the role that you've been assigned to the invite email.

amercader added a commit that referenced this issue Jun 15, 2015

[#1527] Read email subjects from templates as well
As per @wardi's suggestion. Added a new example plugin with tests

amercader added a commit that referenced this issue Jun 15, 2015

amercader added a commit that referenced this issue Jun 15, 2015

amercader added a commit that referenced this issue Jun 16, 2015

amercader added a commit that referenced this issue Dec 9, 2015

amercader added a commit that referenced this issue Dec 9, 2015

amercader added a commit that referenced this issue Dec 9, 2015

wardi added a commit that referenced this issue Jan 7, 2016

Merge pull request #2465 from ckan/1527-custom-emails
[#1527] Allow to customize emails sent from CKAN
@hbunke

This comment has been minimized.

Copy link

commented Jan 27, 2016

What's the status of this issue? The code has been in master for some time now (6654999), but nothing seems to have made it into a release so far.

@TkTech TkTech closed this May 10, 2016

@davidread

This comment has been minimized.

Copy link
Contributor

commented May 24, 2016

This issue was closed due to inactivity. Feel free to reopen if you have more feedback or are interested it working on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.