Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters don't work on graph embed/full screen resource view #2657

Closed
mattfullerton opened this issue Sep 30, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@mattfullerton
Copy link
Contributor

commented Sep 30, 2015

Here I have some very simple CSV data with a filter category=green applied. In the CKAN view the data is filtered and only 3 points show up:
http://beta.ckan.org/dataset/tzest-csv/resource/68e7640e-2e07-4c56-b1d3-70a56cfde467?view_id=d8014a57-b2ee-4de8-9bf9-07c80a8ecb4d

In the embed/view-only view, all points show up:
http://beta.ckan.org/dataset/tzest-csv/resource/68e7640e-2e07-4c56-b1d3-70a56cfde467?view_id=d8014a57-b2ee-4de8-9bf9-07c80a8ecb4d

@joetsoi joetsoi self-assigned this Oct 1, 2015

@mattfullerton

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2016

Highly relevant:

if (window.parent.ckan.views && window.parent.ckan.views.filters) {

and

#2423

mattfullerton added a commit to mattfullerton/ckan that referenced this issue Oct 4, 2016

mattfullerton added a commit to mattfullerton/ckan that referenced this issue Oct 7, 2016

amercader added a commit that referenced this issue Oct 14, 2016

Merge pull request #3266 from mattfullerton/patch-4
Fixes #2657 by not ignoring filters when embedded

amercader added a commit that referenced this issue Oct 14, 2016

amercader added a commit that referenced this issue Oct 14, 2016

amercader added a commit that referenced this issue Oct 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.