Grid view converts CSV column header 'title' to the site title

[MrkGrgsn]

For CSV resources with a column header of 'Title', the grid and data explorer previews displays the site title as the header of this column. The expected behaviour is that it would simply display "Title". Observed in CKAN 2.3.1.

[MrkGrgsn]

Screenshot

[smotornyuk]

What is the purpose of sanitizeFieldName function? Because of it's name, i thought that it removes/encodes all special chars, but instead of it, fieldName used as selector for dom element. Because of this we have that interesting behaviour using column names like 'title', 'div', '#some-id-that-can-appears-on-the-page'. Probably this function must be rewrited to something that really escapes/removes special chars?

[amercader]

@smotornyuk the original goal was to avoid injections as SlickGrid will evaluate the header contents:

datopian/portaljs@0990dce

My solution is obviously not optimal so if you can come up with a better one that would be great

[smotornyuk]

@amercader i created pull request. I prefer this way because it encodes required entities and we haven't need to mess with regExps or any other kind of replacement directly)

[amercader]

Fix for this in #2961