Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group pagination does not preserve sort order #2981

Closed
martinburchell opened this issue Apr 27, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@martinburchell
Copy link
Contributor

commented Apr 27, 2016

CKAN Version if known (or site URL)

2.5.2

Please describe the expected behaviour

On group page, eg http://demo.ckan.org/group the pagination links at the foot of the page should preserve the sort order

Please describe the actual behaviour

The sort order is set to the default

What steps can be taken to reproduce the issue?

Create 22 groups (currently available at http://demo.ckan.org/group)
Go to the group page
Change the sort order to "Name Descending"
Go to page 2

The group on page 2 should be the first alphabetically - instead it's the last

This has already been fixed for organizations - see #2141 and #2153

@amercader amercader self-assigned this Apr 28, 2016

@amercader

This comment has been minimized.

Copy link
Member

commented May 10, 2016

@martinburchell That makes sense, do yo want to send a PR with the group fixes you mention?

@martinburchell

This comment has been minimized.

Copy link
Contributor Author

commented May 19, 2016

Yes if I get time I will. Also happy for others to pick up.

k-nut added a commit to k-nut/ckan that referenced this issue May 20, 2016

[ckan#2981] Preserve sort order in groups on pagination
- Uses the same code that was introuced in ckan#2153 for organizations
- Changes the tests to sort descending so that they actually make sure
  that the sort order is not changed

k-nut added a commit to k-nut/ckan that referenced this issue May 23, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.