Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server error at /organization if not authorized to list organizations #2990

Closed
martinburchell opened this issue Apr 29, 2016 · 1 comment

Comments

Projects
None yet
3 participants
@martinburchell
Copy link
Contributor

commented Apr 29, 2016

CKAN Version if known (or site URL)

2.5.2

Please describe the expected behaviour

The behaviour should be similar to if the user goes to /organization/foo and does not have "organization_show" access ie the user gets logged out and sees a message "Organizations are not available."

Please describe the actual behaviour

Server error:

URL: http://localhost:5000/organization
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/weberror/evalexception.py', line 428 in respond
  app_iter = self.application(environ, detect_start_response)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/webob/dec.py', line 147 in __call__
  resp = self.call_func(req, *args, **self.kwargs)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/webob/dec.py', line 208 in call_func
  return self.func(req, *args, **kwargs)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/fanstatic/publisher.py', line 234 in __call__
  return request.get_response(self.app)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/webob/request.py', line 1053 in get_response
  application, catch_exc_info=False)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/webob/request.py', line 1022 in call_application
  app_iter = application(self.environ, start_response)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/webob/dec.py', line 147 in __call__
  resp = self.call_func(req, *args, **self.kwargs)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/webob/dec.py', line 208 in call_func
  return self.func(req, *args, **kwargs)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/fanstatic/injector.py', line 54 in __call__
  response = request.get_response(self.app)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/webob/request.py', line 1053 in get_response
  application, catch_exc_info=False)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/webob/request.py', line 1022 in call_application
  app_iter = application(self.environ, start_response)
File '/home/martinb/workspace/ckan/lib/default/src/ckan/ckan/config/middleware.py', line 389 in inner
  result = application(environ, start_response)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/beaker/middleware.py', line 73 in __call__
  return self.app(environ, start_response)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/beaker/middleware.py', line 155 in __call__
  return self.wrap_app(environ, session_start_response)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/routes/middleware.py', line 131 in __call__
  response = self.app(environ, start_response)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/pylons/wsgiapp.py', line 125 in __call__
  response = self.dispatch(controller, environ, start_response)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/pylons/wsgiapp.py', line 324 in dispatch
  return controller(environ, start_response)
File '/home/martinb/workspace/ckan/lib/default/src/ckan/ckan/lib/base.py', line 337 in __call__
  res = WSGIController.__call__(self, environ, start_response)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/pylons/controllers/core.py', line 221 in __call__
  response = self._dispatch_call()
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/pylons/controllers/core.py', line 172 in _dispatch_call
  response = self._inspect_call(func)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/pylons/controllers/core.py', line 107 in _inspect_call
  result = self._perform_call(func, args)
File '/home/martinb/workspace/ckan/lib/default/local/lib/python2.7/site-packages/pylons/controllers/core.py', line 60 in _perform_call
  return func(**args)
File '/home/martinb/workspace/ckan/lib/default/src/ckan/ckan/controllers/group.py', line 178 in index
  data_dict_global_results)
File '/home/martinb/workspace/ckan/lib/default/src/ckan/ckan/logic/__init__.py', line 416 in wrapped
  result = _action(context, data_dict, **kw)
File '/home/martinb/workspace/ckan/lib/default/src/ckan/ckan/logic/action/get.py', line 608 in organization_list
  _check_access('organization_list', context, data_dict)
File '/home/martinb/workspace/ckan/lib/default/src/ckan/ckan/logic/__init__.py', line 286 in check_access
  raise NotAuthorized(msg)
NotAuthorized: <function unauthorized at 0x7f1d7e787410> requires an authenticated user

What steps can be taken to reproduce the issue?

Log in with a user that does not have "organization_list" access and go to /organization

@wardi wardi self-assigned this May 3, 2016

@wardi wardi assigned k-nut and unassigned wardi May 19, 2016

@wardi

This comment has been minimized.

Copy link
Contributor

commented May 19, 2016

@k-nut if you've got some time, this looks like a quick one

k-nut added a commit to k-nut/ckan that referenced this issue May 20, 2016

[ckan#2990] Add test for organization_list
- The test makes sure that the response is a 403
- Mosly this is to make sure that the view renders at all and that it
  does not throw an exception in the backend anymore like it used to

k-nut added a commit to k-nut/ckan that referenced this issue May 20, 2016

k-nut added a commit to k-nut/ckan that referenced this issue May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.