Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 2.6 support #3126

Closed
k-nut opened this issue Jun 17, 2016 · 0 comments

Comments

Projects
None yet
2 participants
@k-nut
Copy link
Contributor

commented Jun 17, 2016

It was announced to the mailing list by @amercader in January that support for python 2.6 was going to be dropped with ckan 2.6 (what a wonderful coincidence).

https://lists.okfn.org/pipermail/ckan-dev/2016-January/009608.html

Starting from the next CKAN 2.6 version, the minimum Python version
required for CKAN will be Python 2.7 (we recommend using the latest
Python patch release).

There still are some backports and workaraounds for 2.6 in the code and the documentation needs upgrading.

Grep for 2.6

Python files

ckan/lib/util.py
13:# subprocess.check_output() isn't in Python 2.6.
15:# Python 2.6.

ckan/model/extension.py
17:        "Replaces stdlib operator.methodcaller in python <2.6"

ckan/tests/helpers.py
36:    # Python 2.6 doesn't have these, so define them here

ckanext/datapusher/tests/test.py
87:        # Httpretty crashes with Solr on Python 2.6,

ckanext/resourceproxy/tests/test_proxy.py
63:        # Httpretty crashes with Solr on Python 2.6,

Documentation:

doc/contributing/python.rst
77:We use `the Python standard library's logging module <http://docs.python.org/2.6/library/logging.html>`_

doc/contributing/string-i18n.rst
339:  Worse (doesn't work in Python 2.6):

doc/maintaining/installing/install-from-source.rst
36:Python                 `The Python programming language, v2.6 or 2.7 <http://www.python.org/getit/>`_

I'll prepare a PR to remove all of those things.

k-nut pushed a commit to k-nut/ckan that referenced this issue Jun 17, 2016

k-nut pushed a commit to k-nut/ckan that referenced this issue Jun 17, 2016

Knut Hühne
[ckan#3126] don't check if methodcaller is available
- `operator.methodcaller` was implemented in python2.7. Now that ckan
  only supports 2.7 it is no longer required to check if the import is
  possible or not. We can besure that it is there.

k-nut pushed a commit to k-nut/ckan that referenced this issue Jun 17, 2016

Knut Hühne
[ckan#3126] don't check if methodcaller is available
- `operator.methodcaller` was implemented in python2.7. Now that ckan
  only supports 2.7 it is no longer required to check if the import is
  possible or not. We can besure that it is there.

k-nut pushed a commit to k-nut/ckan that referenced this issue Jun 17, 2016

Knut Hühne
[ckan#3126] remove assert_(not)_in from helpers
- `assert_in` and `assert_not_in` were duplicated
  in `ckan/tests/legacy/__init__.py` and
  `ckan.tests.helpers` because they were not
  available in python2.6
- This commit removes the back porting from those
  files and just imports from nose.tools directly
  everywhere

k-nut pushed a commit to k-nut/ckan that referenced this issue Jun 17, 2016

Knut Hühne
[ckan#3126] remove check for skipping tests
- This was used to skip this test under python2.6 which will not be
  tested anymore in the future

k-nut pushed a commit to k-nut/ckan that referenced this issue Jun 17, 2016

Knut Hühne
[ckan#3126] remove check for skipping tests
- removes some code that was used to skip tests and change solr settings
  under python2.6 which is not tested against anymore

k-nut pushed a commit to k-nut/ckan that referenced this issue Jun 20, 2016

k-nut pushed a commit to k-nut/ckan that referenced this issue Jun 20, 2016

@amercader amercader self-assigned this Jun 21, 2016

k-nut pushed a commit to k-nut/ckan that referenced this issue Jul 4, 2016

k-nut pushed a commit to k-nut/ckan that referenced this issue Jul 4, 2016

Knut Hühne
[ckan#3126] don't check if methodcaller is available
- `operator.methodcaller` was implemented in python2.7. Now that ckan
  only supports 2.7 it is no longer required to check if the import is
  possible or not. We can besure that it is there.

k-nut pushed a commit to k-nut/ckan that referenced this issue Jul 4, 2016

Knut Hühne
[ckan#3126] remove assert_(not)_in from helpers
- `assert_in` and `assert_not_in` were duplicated
  in `ckan/tests/legacy/__init__.py` and
  `ckan.tests.helpers` because they were not
  available in python2.6
- This commit removes the back porting from those
  files and just imports from nose.tools directly
  everywhere

k-nut pushed a commit to k-nut/ckan that referenced this issue Jul 4, 2016

Knut Hühne
[ckan#3126] remove check for skipping tests
- removes some code that was used to skip tests and change solr settings
  under python2.6 which is not tested against anymore

k-nut pushed a commit to k-nut/ckan that referenced this issue Jul 4, 2016

k-nut pushed a commit to k-nut/ckan that referenced this issue Jul 4, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.