Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset follower can't see new item counter at dashboard link, when the dataset is updated. #3373

Closed
Engerrs opened this issue Dec 20, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@Engerrs
Copy link
Member

commented Dec 20, 2016

CKAN Version if known (or site URL)

master(ckan 2.7) branch

Please describe the expected behaviour

When user follows dataset and this dataset is updated, new dashboard item counter should be changed, so user can see that new notifications appeard.

Please describe the actual behaviour

When user follow dataset and this dataset is updated, new dashboard item counter is still on 0 items.

What steps can be taken to reproduce the issue?

Create a new user that follows some dataset, update this dataset. Reload the page with new user and no items appear at the link to dashboard.

Engerrs pushed a commit to Engerrs/ckan that referenced this issue Dec 20, 2016

Yan
[ckan#3373]Dashboard_mark_activities_old is set to utcnow() format
The problem was that dashboard_mark_activities_old method was not changed to utcnow() format, so when datasets were updated, because of the time difference, user have seen them before he actually entered the page.

I've adde utcnow() format for this method and now the time works fine. Also added untnow() to Dashboard model, so the time can be saved correctly.

amercader added a commit that referenced this issue Jan 3, 2017

Merge pull request #3374 from Engerrs/3373-dashboard_mark_activities_…
…old_to_utcnow_time

[#3373]Dashboard_mark_activities_old is set to utcnow() format
@amercader

This comment has been minimized.

Copy link
Member

commented Jan 3, 2017

@Engerrs was this fixed by #3374?

@amercader amercader self-assigned this Jan 3, 2017

@Engerrs

This comment has been minimized.

Copy link
Member Author

commented Jan 3, 2017

@amercader yes.

@amercader

This comment has been minimized.

Copy link
Member

commented Jan 3, 2017

Great, closing this then.

@amercader amercader closed this Jan 3, 2017

amercader added a commit that referenced this issue Feb 14, 2017

[#3373]Dashboard_mark_activities_old is set to utcnow() format
The problem was that dashboard_mark_activities_old method was not changed to utcnow() format, so when datasets were updated, because of the time difference, user have seen them before he actually entered the page.

I've adde utcnow() format for this method and now the time works fine. Also added untnow() to Dashboard model, so the time can be saved correctly.

amercader added a commit that referenced this issue Feb 14, 2017

[#3373]Dashboard_mark_activities_old is set to utcnow() format
The problem was that dashboard_mark_activities_old method was not changed to utcnow() format, so when datasets were updated, because of the time difference, user have seen them before he actually entered the page.

I've adde utcnow() format for this method and now the time works fine. Also added untnow() to Dashboard model, so the time can be saved correctly.

amercader added a commit that referenced this issue Feb 14, 2017

[#3373]Dashboard_mark_activities_old is set to utcnow() format
The problem was that dashboard_mark_activities_old method was not changed to utcnow() format, so when datasets were updated, because of the time difference, user have seen them before he actually entered the page.

I've adde utcnow() format for this method and now the time works fine. Also added untnow() to Dashboard model, so the time can be saved correctly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.