Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing c.action attribute in 2.8.0 templates #4310

Closed
torfsen opened this issue Jun 27, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@torfsen
Copy link
Contributor

commented Jun 27, 2018

It seems that in CKAN 2.8.0, the c.action attribute is at least sometimes missing when templates are being rendered. I can reproduce this for the home/index.html template, which currently breaks ckanext-pages for CKAN 2.8.0 (see ckan/ckanext-pages#78).

It seems that this is a consequence of a change to routing.py as part of #3891, although I'm not sure about that.

@amercader

This comment has been minimized.

Copy link
Member

commented Jun 27, 2018

@smotornyuk can you have a look at this?

@torfsen

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2018

I'm not sure whether this is the same problem, but it seems that c is also missing the controller attribute in some cases in 2.8.0. See stadt-karlsruhe/ckanext-discovery#1.

tino097 added a commit that referenced this issue Jul 23, 2018

Merge pull request #4319 from smotornyuk/flask-views-global-controlle…
…r-and-action

[#4310] Add global properties `controller` and `action`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.