toolkit: add h, StopOnError, DefaultOrganizationForm #2835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wardi
added a commit
to wardi/ckan
that referenced
this pull request
Jan 14, 2016
wardi
added a commit
to wardi/ckan
that referenced
this pull request
Jan 14, 2016
wardi
added a commit
to wardi/ckan
that referenced
this pull request
Jan 14, 2016
wardi
changed the title
Contributor
Author
|
sadly, this doesn't let me |
wardi
force-pushed
the
2835-toolkit-test-helpers-factories
branch
from
ed74b50 to
cc0bb58
Compare
wardi
changed the title
wardi
changed the title
Contributor
Author
|
This now has proper AttributeErrors for missing helpers on As a bonus we can now use |
Contributor
Author
There was a problem hiding this comment.
@brew I moved this out because there's no reason for it to be a classmethod (it never uses cls), and because as a normal function I can do the is _null_function check below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will let me remove all deep ckan imports from ckanext-scheming.
For
hI've chosen to export the same object that the templates see (with all the same side-effects) I think that's better than just exportingckan.lib.helpersbut I would kind of like to have proper AttributeErrors when I mistype a helper name.