Param use_default_schema does not work on package_search #2848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameter needs to be removed before sending the query to Solr Also improved the boolean checking and fixed the docs.
Contributor
|
This looks obviously correct, but should we add a little test to make sure it stays working? |
Contributor
|
@amercader Ok I'll let the tests slide this time because it's a fix we need to backport... |
wardi
added a commit
that referenced
this pull request
Feb 17, 2016
…_search Param use_default_schema does not work on package_search
amercader
added a commit
that referenced
this pull request
Feb 22, 2016
amercader
added a commit
that referenced
this pull request
Mar 16, 2016
The parameter needs to be removed before sending the query to Solr Also improved the boolean checking and fixed the docs.
amercader
added a commit
that referenced
this pull request
Mar 16, 2016
The parameter needs to be removed before sending the query to Solr Also improved the boolean checking and fixed the docs.
amercader
added a commit
that referenced
this pull request
Mar 16, 2016
The parameter needs to be removed before sending the query to Solr Also improved the boolean checking and fixed the docs. Conflicts: ckan/logic/action/get.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1327 made both
package_searchandpackage_showreturn the validated data_dict instead of the default one. In both cases passinguse_default_schema=Trueshould allow to retrieve the unvalidated data_dict, but onpackage_searchis returning an exception:That's because the param is not removed before being sent to Solr