Resolve datastore_delete erasing the database when filters was blank.#2885
Merged
wardi merged 7 commits intockan:masterfrom Mar 11, 2016
Merged
Resolve datastore_delete erasing the database when filters was blank.#2885wardi merged 7 commits intockan:masterfrom
wardi merged 7 commits intockan:masterfrom
Conversation
Contributor
|
@TkTech would you be able to add a quick test for this so that it stays fixed? |
…s, various PEP8 changes.
Member
Author
|
Closing/reopening to force circle.ci to run. |
wardi
added a commit
to wardi/ckan
that referenced
this pull request
Mar 11, 2016
wardi
added a commit
to wardi/ckan
that referenced
this pull request
Mar 11, 2016
Contributor
|
@amercader I trimmed this down to just the fix for easier backporting, see: 4b18505 |
amercader
added a commit
that referenced
this pull request
Mar 16, 2016
amercader
added a commit
that referenced
this pull request
Mar 16, 2016
amercader
added a commit
that referenced
this pull request
Mar 16, 2016
amercader
added
zBackport 2.3.4
zBackport 2.4.3
zBackport 2.5.2
and removed
Backport pending
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny bugfix that corrects datastore_delete behaviour when filters is provided but blank and reflects the behaviour described in the documentation.
Features:
Please [X] all the boxes above that apply