Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve datastore_delete erasing the database when filters was blank. #2885

Merged
merged 7 commits into from Mar 11, 2016

Conversation

Projects
None yet
3 participants
@TkTech
Copy link
Member

commented Feb 24, 2016

This is a tiny bugfix that corrects datastore_delete behaviour when filters is provided but blank and reflects the behaviour described in the documentation.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@wardi wardi self-assigned this Feb 25, 2016

@wardi

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2016

@TkTech would you be able to add a quick test for this so that it stays fixed?

@TkTech TkTech closed this Mar 10, 2016

@TkTech TkTech reopened this Mar 10, 2016

@TkTech

This comment has been minimized.

Copy link
Member Author

commented Mar 10, 2016

Closing/reopening to force circle.ci to run.

wardi added a commit to wardi/ckan that referenced this pull request Mar 11, 2016

wardi added a commit to wardi/ckan that referenced this pull request Mar 11, 2016

@wardi wardi merged commit 822b3a9 into ckan:master Mar 11, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details
@wardi

This comment has been minimized.

Copy link
Contributor

commented Mar 11, 2016

@amercader I trimmed this down to just the fix for easier backporting, see: 4b18505

amercader added a commit that referenced this pull request Mar 16, 2016

amercader added a commit that referenced this pull request Mar 16, 2016

amercader added a commit that referenced this pull request Mar 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.