Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination style (CSS) #3067

Merged
merged 1 commit into from May 31, 2016

Conversation

Projects
None yet
2 participants
@k-nut
Copy link
Contributor

commented May 27, 2016

Fixes #2399

Proposed fixes:

In issue #2399 it is shown that the pagination laps out of the main div. Removing the .module .pagination style fixed that (specifically the height).
I also noticed that the pagination is pretty broken overall. Take a look at the screenshots from the primer below:

Pagination before (from primer)

screen shot 2016-05-27 at 16 20 22

#### Pagination after (from primer)

screen shot 2016-05-27 at 16 22 32

#### Tags page after

screen shot 2016-05-27 at 16 22 58

Most of this was achieved by deleting css rules that to be honest did not really make sense to me.

Do you think there might be other places where this was a wanted behavior of the pagination?

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

k-nut added a commit to k-nut/ckan that referenced this pull request May 27, 2016

@amercader amercader self-assigned this May 31, 2016

@amercader amercader merged commit 1885cba into ckan:master May 31, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@k-nut k-nut deleted the k-nut:2399-pagination-styling branch Jun 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.