Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.
Sign upUncaught email exceptions on user invite #3077
Conversation
This comment has been minimized.
This comment has been minimized.
|
Frustratingly the members page will still list the deleted user that was just created even if the email wasn't send. This is because of #3078 |
amercader
assigned
k-nut
Jun 2, 2016
This comment has been minimized.
This comment has been minimized.
|
@amercader looks good to me |
brew
merged commit a809747
into
master
Jun 6, 2016
1 check passed
ci/circleci
Your tests passed on CircleCI!
Details
amercader
added a commit
that referenced
this pull request
Jun 7, 2016
amercader
removed
zBackport 2.3.5
zBackport 2.4.4
Backport pending
labels
Aug 25, 2016
smotornyuk
deleted the
3077-exceptions-user-invite
branch
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
amercader commentedJun 1, 2016
•
edited
When inviting a user to a group or an organization, either via the UI or the
user_inviteAPI call if there was a problem sending the invite email the exception is not caught, resulting in a 500 error. Common exceptions include[Errno 111] Connection refusedandMailerException: SMTPAuthenticationError(435, '4.7.8 Error: authentication failed:').I think we should delete the pending user (which is already created at this point).
Error returned: