Uncaught email exceptions on user invite #3077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than returning a 500 error, return a ValidationError with the SMTP error, and delete the pending user.
|
Frustratingly the members page will still list the deleted user that was just created even if the email wasn't send. This is because of #3078 |
|
@amercader looks good to me 👍 |
amercader
added a commit
that referenced
this pull request
Jun 7, 2016
Rather than returning a 500 error, return a ValidationError with the SMTP error, and delete the pending user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inviting a user to a group or an organization, either via the UI or the
user_inviteAPI call if there was a problem sending the invite email the exception is not caught, resulting in a 500 error. Common exceptions include[Errno 111] Connection refusedandMailerException: SMTPAuthenticationError(435, '4.7.8 Error: authentication failed:').I think we should delete the pending user (which is already created at this point).
Error returned: