New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckan.__version__ available as template helper #3103

Merged
merged 3 commits into from Jul 14, 2016

Conversation

Projects
None yet
3 participants
@brew
Copy link
Member

brew commented Jun 10, 2016

The BaseController in lib/base.py adds __version__ to c so it's available to the base.html template.

Instead of having this added to c, I suggest removing the line from base.py and add a new template helper, ckan_version, that returns ckan.__version__, for use in templates.

[#3103] Use helper for version instead of context
Instead of adding the ckan version as a value on `c`, this commit adds a
new template helper that returns `ckan.__version__`.
@k-nut

This comment has been minimized.

Copy link
Contributor

k-nut commented Jun 14, 2016

I'll update the changelog on this.

@k-nut

This comment has been minimized.

Copy link
Contributor

k-nut commented Jul 4, 2016

@brew just created a new PR that wants to merge into this branch and updates the changelog with this new change.

Merge pull request #3150 from k-nut/3103-b-update-changelog
Add information about moved helper to changelog

@amercader amercader merged commit ee9d2de into master Jul 14, 2016

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@amercader amercader deleted the 3103-version-tmpl-helper branch Jul 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment