Refactor config/middleware.py to more closely match poc-flask-views#3116
Merged
Refactor config/middleware.py to more closely match poc-flask-views#3116
Conversation
It was starting to become unmanageably large with a lot of separate concerns in one place. - Separate the flask and pylons app code into separate modules. - Separate the common middleware code into a separate module.
Member
|
For the reviewer, the only new thing apart from structure changes that this includes is a monkey-patch on the WebOb library. This was discussed on a past dev meeting, but all the details are in this commit: 09fd630 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help with eventual merging of the Flask migration work (#2971), this PR restructures the CKAN middleware module to more closely match the file structure used by the poc-flask-views branch. This separates the Flask and Pylons apps, and common middleware code into different modules, making it a little easier to work with the separate concerns.