Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor config/middleware.py to more closely match poc-flask-views #3116

Merged
merged 1 commit into from Jun 21, 2016

Conversation

Projects
None yet
3 participants
@brew
Copy link
Member

commented Jun 15, 2016

To help with eventual merging of the Flask migration work (#2971), this PR restructures the CKAN middleware module to more closely match the file structure used by the poc-flask-views branch. This separates the Flask and Pylons apps, and common middleware code into different modules, making it a little easier to work with the separate concerns.

[#3116] Refactor middleware module.
It was starting to become unmanageably large with a lot of separate
concerns in one place.

- Separate the flask and pylons app code into separate modules.
- Separate the common middleware code into a separate module.
@amercader

This comment has been minimized.

Copy link
Member

commented Jun 16, 2016

For the reviewer, the only new thing apart from structure changes that this includes is a monkey-patch on the WebOb library. This was discussed on a past dev meeting, but all the details are in this commit: 09fd630

@wardi wardi merged commit 954205d into master Jun 21, 2016

1 of 2 checks passed

QuantifiedCode We found 4 new issue(s), merge with caution!
Details
ci/circleci Your tests passed on CircleCI!
Details

k-nut pushed a commit to k-nut/ckan that referenced this pull request Jul 4, 2016

[ckan#3116] Refactor middleware module.
It was starting to become unmanageably large with a lot of separate
concerns in one place.

- Separate the flask and pylons app code into separate modules.
- Separate the common middleware code into a separate module.

@smotornyuk smotornyuk deleted the 3116-middleware-refactor branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.