Remove site_url_nice from app_globals
#3117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brew I love PRs like this. keep 'em coming. |
k-nut
pushed a commit
to k-nut/ckan
that referenced
this pull request
Jul 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CKAN Version if known (or site URL)
Master, in the file:
ckan/ckan/lib/app_globals.py
Lines 175 to 178 in b4a9a5b
Just a desire to remove unused code.
Running
git log -p -S site_url_niceon the repository shows this was added to app_globals so a message in a base template could echo a user-friendly url. The template made use of it for one day before the message was changed to output the site title instead. It's not used anywhere else in the codebase. Perhaps an extension is using it, but I doubt it. This sort of thing should be a template helper instead anyway.