Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove site_url_nice from app_globals #3117

Merged
merged 1 commit into from Jun 16, 2016
Merged

Remove site_url_nice from app_globals #3117

merged 1 commit into from Jun 16, 2016

Conversation

@brew
Copy link
Member

@brew brew commented Jun 16, 2016

CKAN Version if known (or site URL)

Master, in the file:

# site_url_nice
site_url_nice = app_globals.site_url.replace('http://', '')
site_url_nice = site_url_nice.replace('www.', '')
app_globals.site_url_nice = site_url_nice

Just a desire to remove unused code.

Running git log -p -S site_url_nice on the repository shows this was added to app_globals so a message in a base template could echo a user-friendly url. The template made use of it for one day before the message was changed to output the site title instead. It's not used anywhere else in the codebase. Perhaps an extension is using it, but I doubt it. This sort of thing should be a template helper instead anyway.

@wardi wardi merged commit 9f59e91 into master Jun 16, 2016
1 check passed
Loading
@wardi
Copy link
Contributor

@wardi wardi commented Jun 16, 2016

@brew I love PRs like this. keep 'em coming.

Loading

k-nut pushed a commit to k-nut/ckan that referenced this issue Jul 4, 2016
@smotornyuk smotornyuk deleted the 3117-site-url-nice branch Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants