Bulk operations don't update the package_revision table #3199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`bulk_update_private`, `bulk_update_public` and ``bulk_update_delete` changed the `package` table and the search index but not the revision table, which caused the changes to not be reflected everywhere. This fixes the model query and adds a bunch of tests.
| model.Session.query(model.package_revision_table) \ | ||
| .filter(model.PackageRevision.id.in_(datasets)) \ | ||
| .filter(model.PackageRevision.owner_org == org_id) \ | ||
| .update(update_dict, synchronize_session=False) |
Contributor
There was a problem hiding this comment.
pretty sure we need to restrict to the latest revision here, don't we?
This code was changed in 0413e25#diff-4b95e302501a681a72c099ecc904de3dL1293 there should be a current=True in this query
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
`bulk_update_private`, `bulk_update_public` and ``bulk_update_delete` changed the `package` table and the search index but not the revision table, which caused the changes to not be reflected everywhere. This fixes the model query and adds a bunch of tests. Conflicts: ckan/tests/logic/action/test_update.py
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
`bulk_update_private`, `bulk_update_public` and ``bulk_update_delete` changed the `package` table and the search index but not the revision table, which caused the changes to not be reflected everywhere. This fixes the model query and adds a bunch of tests. Conflicts: ckan/new_tests/logic/action/test_update.py
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
`bulk_update_private`, `bulk_update_public` and ``bulk_update_delete` changed the `package` table and the search index but not the revision table, which caused the changes to not be reflected everywhere. This fixes the model query and adds a bunch of tests. Conflicts: ckan/tests/logic/action/test_update.py
amercader
added a commit
that referenced
this pull request
Aug 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bulk_update_private,bulk_update_publicandbulk_update_deletechange thepackagetable and the search index but not the revision table, which causes the changes to not be reflected everywhere.This fixes the model query and adds a bunch of tests.