New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zh cn translation formatter fix #3238

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@mihail-ivanov
Copy link

mihail-ivanov commented Sep 12, 2016

Fixes #
Chinese translation for ckan/lib/formatters.py in localised_nice_date. String format keys were translated too, which was causing a lot of WebApp Error: <type 'exceptions.KeyError'>: u'\u6708' exceptions.

Proposed fixes:

Set the correct keys for date format string.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@mihail-ivanov mihail-ivanov force-pushed the governmentbg:zh_CN-translation-formatter-fix branch from 88466bd to 9eef1d6 Sep 12, 2016

@mihail-ivanov

This comment has been minimized.

Copy link

mihail-ivanov commented Sep 12, 2016

I force pushed the branch, because I forgot to reset with upstream/master.

@amercader amercader self-assigned this Sep 13, 2016

amercader added a commit that referenced this pull request Sep 14, 2016

@amercader

This comment has been minimized.

Copy link
Member

amercader commented Sep 14, 2016

Thanks @mihail-ivanov, fixed in master in d73326a and backported to 2.5.3

@amercader amercader closed this Sep 14, 2016

amercader added a commit that referenced this pull request Sep 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment