Skip to content

Zh cn translation formatter fix#3238

Closed
mihail-ivanov wants to merge 1 commit intockan:masterfrom
governmentbg:zh_CN-translation-formatter-fix
Closed

Zh cn translation formatter fix#3238
mihail-ivanov wants to merge 1 commit intockan:masterfrom
governmentbg:zh_CN-translation-formatter-fix

Conversation

@mihail-ivanov
Copy link
Copy Markdown

@mihail-ivanov mihail-ivanov commented Sep 12, 2016

Fixes #
Chinese translation for ckan/lib/formatters.py in localised_nice_date. String format keys were translated too, which was causing a lot of WebApp Error: <type 'exceptions.KeyError'>: u'\u6708' exceptions.

Proposed fixes:

Set the correct keys for date format string.

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

Please [X] all the boxes above that apply

@mihail-ivanov mihail-ivanov force-pushed the zh_CN-translation-formatter-fix branch from 88466bd to 9eef1d6 Compare September 12, 2016 08:34
@mihail-ivanov
Copy link
Copy Markdown
Author

I force pushed the branch, because I forgot to reset with upstream/master.

@amercader amercader self-assigned this Sep 13, 2016
amercader added a commit that referenced this pull request Sep 14, 2016
@amercader
Copy link
Copy Markdown
Member

Thanks @mihail-ivanov, fixed in master in d73326a and backported to 2.5.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants