New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faster datastore total calculation + make optional #3467

Merged
merged 2 commits into from Mar 24, 2017

Conversation

Projects
None yet
2 participants
@wardi
Contributor

wardi commented Mar 6, 2017

This PR separates the total rows calculation from the select statement in datastore_search, which for large tables can give a significant speed improvement. It also adds an include_total parameter to datastore_search (default True for backwards compatibility) that allows skipping the calculation completely.

@amercader

This comment has been minimized.

Show comment
Hide comment
@amercader

amercader Mar 24, 2017

Member

This looks great but can you merge master @wardi? There is a conflict involving the new stuff you've worked on that I'd prefer you checked first.

Member

amercader commented Mar 24, 2017

This looks great but can you merge master @wardi? There is a conflict involving the new stuff you've worked on that I'd prefer you checked first.

@wardi

This comment has been minimized.

Show comment
Hide comment
@wardi

wardi Mar 24, 2017

Contributor

@amercader done

Contributor

wardi commented Mar 24, 2017

@amercader done

@amercader amercader merged commit af2f061 into master Mar 24, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
ci/circleci Your tests passed on CircleCI!
Details

@amercader amercader deleted the 3467-datastore-total branch Mar 24, 2017

wardi added a commit to wardi/ckan that referenced this pull request Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment