New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datastore_search fix: total incorrect when distinct=true #4236

Merged
merged 3 commits into from Aug 17, 2018

Conversation

Projects
None yet
3 participants
@wardi
Copy link
Contributor

wardi commented May 7, 2018

PR with test in progress

wardi added a commit that referenced this pull request May 7, 2018

@wardi wardi changed the title datastore_search regression: total incorrect when distinct=true datastore_search fix: total incorrect when distinct=true May 7, 2018

@wardi

This comment has been minimized.

Copy link
Contributor

wardi commented May 7, 2018

not a regression, looks like it was never working correctly 6071824

@wardi

This comment has been minimized.

Copy link
Contributor

wardi commented Aug 16, 2018

@amercader anything holding this up?

@amercader amercader merged commit 047b3f3 into master Aug 17, 2018

4 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk No dependency changes
Details

@tino097 tino097 removed the zBackport 2.6.7 label Dec 4, 2018

@smotornyuk smotornyuk deleted the 4236-datastore-total-fix branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment