New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocomplete.js: fix handling of comma key codes #4421

Merged
merged 1 commit into from Aug 28, 2018

Conversation

Projects
None yet
3 participants
@OriHoch
Copy link
Contributor

OriHoch commented Aug 23, 2018

Fixes a bug with the autocomplete.js module regarding handling of comma for tag separator

Reproduction

  • Create a new dataset
  • In the tags field - using a hebrew keyboard - type the letter ת (which is the same key code as comma in english / latin keyboards)
  • The bug is only reproduced if you type the letter, it does not reproduce using copy/paste
expected
  • write ת
actual
  • does not write the ת
  • starts a new tag

notes

Bug should be fixed for all browsers except IE8. For IE8 - the bug might persist due to missing key attribute in keyboard event. (In that case it falls back to using the key code)

  • includes tests covering changes

@OriHoch OriHoch force-pushed the OriHoch:autocomplete-module-fix-handling-of-commas-in-different-locales branch from 10675a9 to ac199f4 Aug 23, 2018

@amercader amercader merged commit 4011f56 into ckan:master Aug 28, 2018

3 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
security/snyk - requirements.txt (davidread) No manifest changes detected
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment