New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix i18n API encoding #4505

Merged
merged 2 commits into from Oct 18, 2018

Conversation

Projects
None yet
3 participants
@bzar
Copy link
Contributor

bzar commented Oct 17, 2018

Fixes #4504

Proposed fixes:

  • Make i18n_js_translations call _finish_ok with an object response data like all the others
  • Fix _finish and _finish_ok documentation to reflect the expected response_data type for "json" content_type

Features:

  • includes tests covering changes
  • includes updated documentation
  • includes user-visible changes
  • includes API changes
  • includes bugfix for possible backport

bzar added some commits Oct 17, 2018

Fix i18n API encoding
- Make `i18n_js_translations` call `_finish_ok` with an object response data like all the others
- Fix `_finish` and `_finish_ok` documentation to reflect the expected `response_data` type for "json" `content_type`
Fix documentation style
Split long documentation lines

@amercader amercader self-assigned this Oct 18, 2018

@amercader amercader merged commit 70128fb into ckan:master Oct 18, 2018

2 checks passed

ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@amercader

This comment has been minimized.

Copy link
Member

amercader commented Oct 18, 2018

Thanks @bzar!

@tino097

This comment has been minimized.

Copy link
Member

tino097 commented Oct 26, 2018

@amercader i've checked, this dont need to be backported to 2.7.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment