New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to define legacy route mappings as a dict in config #4521

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
2 participants
@amercader
Copy link
Member

amercader commented Oct 25, 2018

The current code only updates the core default list if the ckan.legacy_route_mappings is a string (which is probably how it comes from the ini file). But this setting can also be set by extensions directly on the config object, and it makes more sense to do it as a dict.

Allow to defined legacy route mappings as a dict in config
The current code only updates the core default list if the
`ckan.legacy_route_mappings` is a string (which is probably how it comes
from the ini file). But this setting can also be set by extensions
directly on the config object, and it makes more sense to do it as a
dict.

@tino097 tino097 merged commit e04a753 into master Oct 26, 2018

3 checks passed

ci/circleci: test Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@smotornyuk smotornyuk deleted the legacy-route-mappings-as-dict branch Dec 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment