Disable streaming for pylons requests, fixes ckan/ckan#4431#4657
Merged
smotornyuk merged 1 commit intockan:masterfrom Apr 11, 2019
Merged
Disable streaming for pylons requests, fixes ckan/ckan#4431#4657smotornyuk merged 1 commit intockan:masterfrom
smotornyuk merged 1 commit intockan:masterfrom
Conversation
Contributor
|
This will affect streaming downloads for datastore dump. Maybe that's something that we can live with and fix once migrating the datastore extension to flask? |
Contributor
|
@smotornyuk can we merge this now? the datastore controller will have to be replaced with a flask view anyway |
Member
|
Yes, in that case i see no problems with this change |
alexandru-m-g
added a commit
to OCHA-DAP/hdx-ckan
that referenced
this pull request
Apr 21, 2019
More info: (Fix could cause problems with streaming downloads for datastore dump) ckan/ckan#4431 ckan/ckan#4657
Zharktas
added a commit
to vrk-kpa/api-catalog
that referenced
this pull request
Apr 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4431
Proposed fixes:
Disable streaming responses for pylons as they cause threading issues under heavy load.
Features:
Please [X] all the boxes above that apply