Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing arguments to the RQ enqueue_call function #5208

Merged
merged 5 commits into from
Feb 18, 2020

Conversation

amercader
Copy link
Member

Right now you can only pass the timeout argument to the RQ enqueue_call invocation that we use on toolkit.enqueue_job() (added in #4601), but there are other useful arguments that can be passed, like depends_on, ttl etc

Rather than explicitly allow just one of them, it's better to just pass through all of them.

This is backwards compatible, so I proposed we backport it to at least 2.8

Right now you can only pass the `timeout` argument to the
RQ `enqueue_call` invocation that we use on `toolkit.enqueue_job()`, but
there are other useful arguments that can be passed, like `depends_on`,
`ttl` etc

Rather than explicitly allow just one of them, it's better to just pass
through all of them.
@amercader
Copy link
Member Author

Remove the timeout kw

@amercader amercader added the WIP label Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants