Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a googleanalytics_fields key to
True
as in #25 causes the resulting Javascript to also include the literalTrue
, which is not valid.This works around that by setting the key to
'true'
which when evaluated in an if statement is truthy, serving the same purposeI also tried using
{{h.dump_json(googleanalytics_fields)|safe}}
and loading that in usingJSON.parse
, buth.dump_json
seems to return invalid JSON when used in a template