Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style.js to treat blockquotes as objects. #105

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@ghost
Copy link

commented Jun 6, 2014

Hi,

Blockquotes are broken as inline elements and don't work how I'd expect as a block element but the object element category fits perfectly.

Once correctly set as an object element, you can have paragraphs inside the blockquote and pressing "enter" creates a new <p> tag rather than a new <blockquote> tag.

Also, this allows us to define a blockquote level style.

This appears to have been a previously identified issue here - http://dev.ckeditor.com/ticket/1009 - and I'm having the exact same problem as mentioned there.

Update style.js to treat blockquotes as objects.
Hi,

Blockquotes are broken as inline elements and don't work how I'd expect as a block element but the object element category fits perfectly.

Once correctly set as an object element, you can have paragraphs inside the blockquote and pressing "enter" creates a new <p> tag rather than a new <blockquote> tag.

Also, this allows us to define a blockquote level style.

This appears to have been a previously identified issue here - http://dev.ckeditor.com/ticket/1009 - and I'm having the exact same problem as mentioned there.
@Reinmar

This comment has been minimized.

Copy link
Member

commented Jun 10, 2014

Hey,

Thanks for this PR.

Two questions before we'll be able to evaluate this change:

  1. Can you create a ticket on http://dev.ckeditor.com for an issue you're referring to? I have some assumptions what do you mean, but I want to be sure.
  2. Are you sure you meant http://dev.ckeditor.com/ticket/1009?
@ghost

This comment has been minimized.

Copy link
Author

commented Jun 10, 2014

Hi, sorry the link should have been http://dev.ckeditor.com/ticket/10091. I've created a new ticket - https://dev.ckeditor.com/ticket/12092.

Thanks

@Reinmar

This comment has been minimized.

Copy link
Member

commented Jun 11, 2014

I merged your pull request to master with 449b491. Thanks!

@Reinmar Reinmar closed this Jun 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.