New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix more selection trouble in iOS6 and 7 #10714 #110

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@remiremi

remiremi commented Jun 27, 2014

The pull request #82 fixed most issues for bug http://dev.ckeditor.com/ticket/10714, but this fixes these additional issues:

Environment: iOS6 and iOS7

A.

  1. Click on a disabled button
  2. Notice the cursor is blinking in the right place
  3. Input some text
  4. Notice text is not input

B.

  1. Create a table with the table plugin
  2. Cursor is blinking inside the newly created table
  3. Input some text
  4. Notice text is not input
@pjasiun

This comment has been minimized.

Member

pjasiun commented Sep 1, 2014

Thank you for your contribution. As I see you fixed two separate issue with these commits.

The first one ("Fix more selection trouble in iOS6 and 7 #10714") is the focus problem described in your post. I tested it and your commit in fact fix the issue so I created a ticket for it (http://dev.ckeditor.com/ticket/12381), fixed the code style and put it on review as a potential bug fix for the next minor release.

The second one ("Fix dialog appearing off-centered with keyboard active on the iPad") needs more description, because I do not see what is the problem. Also you changed showCover which is now asynchronous what might be the reason of new problems (dialog is shown without the timeout so before the cover, that seems to be wrong). Please describe what the bug is this fix for and try to find more synchronized solution if it is possible.

@pjasiun

This comment has been minimized.

Member

pjasiun commented Sep 3, 2014

First part of your changes is already in the master branch. Thanks again for debugging and contribution.

@remiremi

This comment has been minimized.

remiremi commented Sep 3, 2014

Hi Piotr. Thanks for merging the first fix! I think I included the second
fix in the pull request by accident, but now that it's there here are some
details :)

I know making showCover asynchronous is not ideal, but I needed a quick fix
to my problem. On some older iPads, the dialog and the overlay appear
vertically off-centered. I think the reason is that the keyboard popups
with an animation. The dialog is positioned while the keyboard is in the
middle of the animation. Once the animation is complete, the dialog's
position is not refreshed, so the dialog seems to be "pushed upwards". I
wish I could take a screenshot but unfortunately I don't have access to any
iPad anymore.

This issue is probably not super important because it only affected older
iPads (2 & 3 were affected if I remember well).

On Wed, Sep 3, 2014 at 11:33 AM, Piotr Jasiun notifications@github.com
wrote:

First part of your changes is already in the master branch. Thanks again
for debugging and contribution.


Reply to this email directly or view it on GitHub
#110 (comment).

@pjasiun

This comment has been minimized.

Member

pjasiun commented Sep 3, 2014

Ok, so I will close this PR in this state. Merging timeout into the master branch could be the reason of some problems and since it fix only old iPads issue it is now very important, as you said.

@pjasiun pjasiun closed this Sep 3, 2014

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment