Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to ensure any ascendant tables found are within editor #137

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@Paul-Martin
Copy link

commented Oct 13, 2014

When tableresize plugin attempts to determine if mouse is currently
over a table, it performs a search of the ascendants of the event
target. However this search will continue outside of the editable
container, and thus find tables in which the editable may be
embedded. This fix adds a check to ensure any found table is in
fact a descendant of the editable container.

Paul Martin
Fix to ensure any ascendant tables found are within editor
When tableresize plugin attempts to determine if mouse is currently
over a table, it perform a search of the ascendants of the event
target.  However this search will continue outside of the editable
container, than thus find tables in which the editable may be
embedded.  This fix ads a check to ensure any found table is in
fact a descendant of the editable container.
@oleq

This comment has been minimized.

Copy link
Member

commented Oct 17, 2014

Thank you for the patch! CKEditor team will review it and, if everything's alright, include it in a minor release.

@adelura

This comment has been minimized.

Copy link
Contributor

commented Jan 15, 2015

Related ticket on the Trac - #12825.

@adelura

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2015

Thanks for PR! We merged it in a66138e.

@adelura adelura closed this Jan 16, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.