Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filter.js #139

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@timselier
Copy link
Contributor

commented Oct 29, 2014

Added a check whether "DTD[ parent.name ]" exists, before accessing "DTD[ parent.name ] && DTD[ parent.name ][ child.name ]".
Otherwise, if you have some exotic tag in your HTML, the scripts would throw an exception because no DTD definition would exist for that tag. Ofcourse you should only use valid HTML, but when you don't, you don't want the whole editor to breakdown.

Gr. Tim Selier,

Update filter.js
Added a check whether "DTD[ parent.name ]" exists, before accessing "DTD[ parent.name ] && DTD[ parent.name ][ child.name ]".
Otherwise, if you have some exotic tag in your HTML, the scripts would throw an exception.
@Reinmar

This comment has been minimized.

Copy link
Member

commented Nov 19, 2014

Thanks for the patch. It wasn't fully complete, because the filter was still throwing exceptions for the tests I created, so I pushed one more commit.

@Reinmar Reinmar closed this Nov 19, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.