Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Uncaught SecurityError for Chrome/IE #153

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@thecatontheflat
Copy link
Contributor

commented Dec 20, 2014

This PR fixes the issue when trying to init CKEditor inline within an iframe

@Reinmar

This comment has been minimized.

Copy link
Member

commented Dec 23, 2014

Thanks for the PR. But before we can merge it, could you describe how the issue can be reproduced?

@thecatontheflat

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2014

@Reinmar Yes, you're right! I will create the sandbox in the meanwhile and post it here

@thecatontheflat

This comment has been minimized.

Copy link
Contributor Author

commented Dec 23, 2014

This bug happens when you include a page with the CKEditor in the iframe to a page on another URL

I tried to create a sandbox for reproducing, but it is really difficult to create such environment somewhere only for showing the issue. You can reproduce it like this:

  1. Create CKEditor page with inline editing on URL A
  2. Include page A in the iframe on page with URL B

Real life scenario - JIRA Cloud Add-On, where the code gets inserted in the iframe.

I've also captured a video: https://www.youtube.com/watch?v=vqtK3QCbPss

@Reinmar

This comment has been minimized.

Copy link
Member

commented Jan 13, 2015

Thanks for the details. I confirmed the issue and reported it on our Trac (http://dev.ckeditor.com/ticket/12812).

To accept the patch we need tests (a manual and an automated one if possible), but in this case it requires a deep knowledge about our testing system, so I've started working on this: https://github.com/cksource/ckeditor-dev/commits/t/12812

@Reinmar

This comment has been minimized.

Copy link
Member

commented Jan 14, 2015

I merged the PR to master with 33557ff.

Thanks!

@Reinmar Reinmar closed this Jan 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.