Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added functionality "previewPostProcess" #19

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
7 participants
@florisluiten
Copy link

commented Jan 2, 2013

Added "previewPostProcess". This function is called when generating a preview (and should return a proper formatted HTML document) and can be used to postprocess the data from the CKEditor instance (ie in a CMS environment).

florisluiten
Update plugins/preview/plugin.js
Added "previewPostProcess". This function is called when generating a preview (and should return a proper formatted HTML document) and can be used to postprocess the data from the CKEditor instance (ie in a CMS environment).
@Reinmar

This comment has been minimized.

Copy link
Member

commented Jan 3, 2013

Hi. Thanks for your proposal. It's an interesting idea and most likely we'll include it in 4.1 (next major release). However, I'm not sure about the design. Perhaps we'll implement it as an event (like getData), because it'd make it more flexible.

@Reinmar

This comment has been minimized.

Copy link
Member

commented Jan 3, 2013

I created ticket for this pull request: #9907.

@florisluiten

This comment has been minimized.

Copy link
Author

commented Jan 3, 2013

Hey thanks for your reply. When looking around on the WWW if found a couple of ppl wanting to do the same as me (customizing the preview), so I thought not only to build it for me but also to share.
I haven't dug enough in the source code to find out how to implement it as an event (confession: I'm more of a backend programmer) but I guess I'll wait for the 4.1 release then. For now my "not so brilliant implementation" will suffice for my purpose :-)

Good luck with the dev. Must say the 4.0 release is a major improvement - keep up the good job!

@wwalc

This comment has been minimized.

Copy link
Member

commented Jan 15, 2013

Hmm this function should rather receive "sHTML" variable as an argument, at the very end. To not alter anything else, just the content to be displayed.

@MattiJarvinen

This comment has been minimized.

Copy link

commented Jan 25, 2013

Isn't the normal preview tool getting the real HTML output anyway (getData?), if any post processing on CMS side is needed aren't we talking about something not in scope of CKEditor.

So couldn't we just make a server side preview plugin based on current preview plugin with posting the contents to the server and post process there instead? Like the previous server side preview tools http://dev.ckeditor.com/ticket/5989

Or am I just missing some point in here?

@fredck

This comment has been minimized.

Copy link
Contributor

commented Feb 14, 2013

We're making it "event driven" with http://dev.ckeditor.com/ticket/9907, so it is up to the hosting application to do any kind of post-processing to the data, either though JavaScript code or sync served requests (the ajax way).

@oleq

This comment has been minimized.

Copy link
Member

commented Feb 15, 2013

This feature is now officially a part of CKEditor 4.1 (https://dev.ckeditor.com/ticket/9907#comment:5).

@florisluiten

This comment has been minimized.

Copy link
Author

commented Feb 15, 2013

Thanks you guys! Making some lifes better!

@Reinmar

This comment has been minimized.

Copy link
Member

commented Feb 17, 2013

As the #9907 was merged to major it's time to close this ticket.

@Reinmar Reinmar closed this Feb 17, 2013

@rohmanahmad

This comment has been minimized.

Copy link

commented Mar 29, 2013

hello sir... can you give me some info for add upload_tab from image properties...

thank you sir... you can reply on my email... rohmanshared@yahoo.com
i'm sorry sir i can't speak english fluently....

@Reinmar

This comment has been minimized.

Copy link
Member

commented Mar 30, 2013

The issue page definitely isn't the right place to ask your question. Use our forum - http://ckeditor.com/forums

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Oct 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.