Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix errors in image plugin when removing htmlPreview from dialog definition #83
Thanks for the Pull Request!
Generally PR looks good, I've tested your changes and it works correctly. There are only very minor things to be changed in your patch, I've pointed them in code comments.
But still I would like to ask you for the Use Case ( so essentially the code ) which you use to remove
Thanks for review. I was really busy last time, but I'm going to introduce provided suggestions this weekend.
And about the Use Case: I would like to have really simple dialog for image includes in comments module I'm trying to write for (amateur cyclist's) team page. Below are code and image (dialog in polish locale, contains only url, alternative text and url on second tab).