Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new config option floatSpacePreferRight #89

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@InvisibleBacon
Copy link

commented Mar 31, 2014

We use the inline editor in our project and wanted the toolbar to align to the right of the editor. This change adds the new option. It mimics the behavior triggered by the "rtl" contentsLangDirection.

roughee added a commit to Scripler/ckeditor-scripler that referenced this pull request Apr 10, 2014

@oleq

This comment has been minimized.

Copy link
Member

commented Jun 27, 2014

Terribly sorry for delay! I moved this PR to http://dev.ckeditor.com/ticket/12143 (4.2.3).

@Reinmar

This comment has been minimized.

Copy link
Member

commented Jun 30, 2014

As I commented in http://dev.ckeditor.com/ticket/12143#comment:3, this patch is incomplete. I think that the last part of the condition has to be mirrored as well when this option is enabled.

@oleq

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

Closed with 17e7031. Thanks @InvisibleBacon!

@oleq oleq closed this Aug 1, 2014

@Reinmar

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

Add @since tag to the option doc.

@oleq

This comment has been minimized.

Copy link
Member

commented Aug 1, 2014

@Reinmar Nice catch!

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Feb 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.