Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for internal pages in link dialog #9

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@martinkronstad
Copy link

martinkronstad commented Nov 6, 2012

Wanted to let you know of a new feature we created for the ckeditor, this changeset will allow the users to define a set of ready made links for internal pages, or a set of pre-defined links.

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Nov 6, 2012

Hi,
Thanks for letting us now :). We'll check this feature after releasing 4.0.0, because now we're in stabilization phase.

@mattleff

This comment has been minimized.

Copy link
Contributor

mattleff commented Nov 21, 2012

👍

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Dec 11, 2012

I created ticket and set milestone 4.1 (it's planned for Feb).

@martinkronstad

This comment has been minimized.

Copy link
Author

martinkronstad commented Dec 11, 2012

This is great news! Thanx for adding it to CKEditor

@mattleff

This comment has been minimized.

Copy link
Contributor

mattleff commented Dec 20, 2012

What if the urls were loaded by AJAX request? That would prevent the need to customize the config.js as links are changed/added/removed.

@martinkronstad

This comment has been minimized.

Copy link
Author

martinkronstad commented Dec 21, 2012

I am sure that would be a good feature to add also, maybe just have a setting for where to call to get the links, then the links could be sent as JSON and then parsed by the link-dialog.

What we are doing now is adding a custom config-file when creating the ckeditor, then we use a php-file as a config-file and have dynamic config per customer.

This way we can have different links, css-style-sheets and so on.

This is a way to do it:

    $(document).ready(function() {
            CKEDITOR.replace( "id-of-textarea",{
                customConfig : "/ckeditor/config.php"   
               }   
            );              
        });');

We actually also allow more custom config to be passed to our ckeditor-instantiator:

    CMSRenderer::AddJs('$(document).ready(function() {
            CKEDITOR.replace( "' . $strName . '",{
                '.$strConfig.'
                extraPlugins : "'.$strExtraPlugin.'",
                toolbar : "' . $strType . '",
                customConfig : "/ckeditor/config.php"   
               }   
            );              
        });');

This way we can generate the links and fetch them only once per form.

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Mar 22, 2013

Small update: we've just released CKEditor 4.1, but we weren't able to review your code. Because of Drupal's requirements we've got milestone 4.2 full too, so it's unlikely that we will work on internal links before 4.3.

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013

mdenburger pushed a commit to onehippo/ckeditor that referenced this pull request Dec 3, 2013

@martinkronstad

This comment has been minimized.

Copy link
Author

martinkronstad commented Jan 15, 2014

What is the status on this pull request?, is it going to be added to CKEditor any time soon?

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Jan 15, 2014

Hi,

We are not planning support for external links at the moment. There are couple of other features on which we are focused and unless there will be a change in our plans at least until CKE 4.5 we won't work on this.

The main problem with feature like this is that we don't know how it should work in a first place. Therefore, I cannot even give you an answer if we like the implementation - I simply don't know without earlier analysis. So we keep your pull request as a source of ideas in case this feature appears in our plans.

@sebastiansulinski

This comment has been minimized.

Copy link

sebastiansulinski commented May 26, 2014

Not sure if anyone will find this useful, but I've done a video on how to add internal links dropdown to the Link and Image dialog of the CKEditor: http://www.ssdtutorials.com/tutorials/title/ckeditor-internal-page-link.html

mdenburger added a commit to onehippo/ckeditor that referenced this pull request Oct 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.