From 894b6f1bf95a10a33de3ad416c9cebcad36b0781 Mon Sep 17 00:00:00 2001 From: "David N. Welton" Date: Mon, 23 Dec 2013 23:45:05 +0100 Subject: [PATCH 1/3] Chrome needs some help selecting page breaks too. Firefox seems to be able to select them without problems. I don't have IE to test with. --- plugins/pagebreak/plugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/pagebreak/plugin.js b/plugins/pagebreak/plugin.js index f2b39f0c6ee..563c793900f 100644 --- a/plugins/pagebreak/plugin.js +++ b/plugins/pagebreak/plugin.js @@ -46,7 +46,7 @@ CKEDITOR.plugins.add( 'pagebreak', { } ); // Opera needs help to select the page-break. - CKEDITOR.env.opera && editor.on( 'contentDom', function() { + (CKEDITOR.env.opera || CKEDITOR.env.chrome) && editor.on( 'contentDom', function() { editor.document.on( 'click', function( evt ) { var target = evt.data.getTarget(); if ( target.is( 'div' ) && target.hasClass( 'cke_pagebreak' ) ) From e40cf260ed41b741cc6473a3ec8dc12f9c6deec1 Mon Sep 17 00:00:00 2001 From: "m.lewandowski" Date: Mon, 17 Feb 2014 11:08:20 +0100 Subject: [PATCH 2/3] Comment updated. --- plugins/pagebreak/plugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/pagebreak/plugin.js b/plugins/pagebreak/plugin.js index ea04704588b..de85993e31a 100644 --- a/plugins/pagebreak/plugin.js +++ b/plugins/pagebreak/plugin.js @@ -46,7 +46,7 @@ toolbar: 'insert,70' } ); - // Opera needs help to select the page-break. + // Opera and Chrome needs help to select the page-break. ( CKEDITOR.env.opera || CKEDITOR.env.chrome ) && editor.on( 'contentDom', function() { editor.document.on( 'click', function( evt ) { var target = evt.data.getTarget(); From 478aa10ab62d3c51e4caec2825f7a62593521d57 Mon Sep 17 00:00:00 2001 From: "m.lewandowski" Date: Mon, 17 Feb 2014 11:27:16 +0100 Subject: [PATCH 3/3] Changelog entry. --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index 1b4d7922680..e0745894112 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -5,6 +5,7 @@ CKEditor 4 Changelog Fixed Issues: +* [#8673](http://dev.ckeditor.com/ticket/8673): Fixed: Chrome - cannot select and remove Page Break (pagebreak). * [#11413](http://dev.ckeditor.com/ticket/11413): Fixed: Wrong execCommand behavior. * [#11438](http://dev.ckeditor.com/ticket/11438): Splitting table cells vertically is no longer chnaging table structure. * [#8899](http://dev.ckeditor.com/ticket/8899): Fixed: Links in About Dialog now open in new window/tab.