From 70862b1ab8b943cd16c03174b78dea4c9006e339 Mon Sep 17 00:00:00 2001 From: Artur Delura Date: Fri, 24 Apr 2015 11:07:03 +0200 Subject: [PATCH 1/3] Tests: Written manual one for issue. --- .../notification/manual/notificationposition.html | 10 ++++++++++ .../notification/manual/notificationposition.md | 5 +++++ 2 files changed, 15 insertions(+) create mode 100644 tests/plugins/notification/manual/notificationposition.html create mode 100644 tests/plugins/notification/manual/notificationposition.md diff --git a/tests/plugins/notification/manual/notificationposition.html b/tests/plugins/notification/manual/notificationposition.html new file mode 100644 index 00000000000..12cdb5dae87 --- /dev/null +++ b/tests/plugins/notification/manual/notificationposition.html @@ -0,0 +1,10 @@ + + diff --git a/tests/plugins/notification/manual/notificationposition.md b/tests/plugins/notification/manual/notificationposition.md new file mode 100644 index 00000000000..4fc779a38eb --- /dev/null +++ b/tests/plugins/notification/manual/notificationposition.md @@ -0,0 +1,5 @@ +@bender-tags: 4.5.0, tc +@bender-ui: collapsed +@bender-ckeditor-plugins: wysiwygarea, toolbar, notification + +Notification should be centered horizontally. From f63324bcaeac11faf147216042b311381dfe04a0 Mon Sep 17 00:00:00 2001 From: Artur Delura Date: Fri, 15 May 2015 17:25:29 +0200 Subject: [PATCH 2/3] Notification centering takes margin into consideration. --- plugins/notification/plugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/notification/plugin.js b/plugins/notification/plugin.js index 0ae40ed8755..31c78fa0727 100644 --- a/plugins/notification/plugin.js +++ b/plugins/notification/plugin.js @@ -830,7 +830,7 @@ Area.prototype = { } function setCenter() { - area.setStyle( 'left', cssLength( leftBase + contentsRect.width / 2 - notificationWidth / 2 ) ); + area.setStyle( 'left', cssLength( leftBase + contentsRect.width / 2 - notificationWidth / 2 - notificationMargin / 2 ) ); } function setRight() { From 15fca0f4827aa838adb66715c351ea6aad0bfc84 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Piotrek=20Koszuli=C5=84ski?= Date: Fri, 15 May 2015 17:52:58 +0200 Subject: [PATCH 3/3] Changelog entry. --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index 62830238d41..e81fdf7bc1f 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -11,6 +11,7 @@ Fixed Issues: * [#13199](http://dev.ckeditor.com/ticket/13199): Fixed: Embedsemantic does not support widget classes. * [#13003](http://dev.ckeditor.com/ticket/13003): Fixed: Anchors are uploaded when moving them by drag and drop. * [#13032](http://dev.ckeditor.com/ticket/13032): Fixed: When upload is done notification update should be marked as important. +* [#13036](http://dev.ckeditor.com/ticket/13036): Fixed: Notifications are 10px more to the right. * Toolbar configurators: * [#13185](http://dev.ckeditor.com/ticket/13185): Fixed: Wrong position of the suggestion box if there is not enough space below the caret. * [#13138](http://dev.ckeditor.com/ticket/13138): Fixed: The "Toggle empty elements" button label is unclear.