Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests covering headers manipulation in table plugin #2882

Closed
f1ames opened this issue Mar 4, 2019 · 1 comment
Closed

Add unit tests covering headers manipulation in table plugin #2882

f1ames opened this issue Mar 4, 2019 · 1 comment
Assignees
@Dumluregn
Labels
changelog:skip A changelog entry should not be added for a given issue. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:table The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:task Any other issue (refactoring, typo fix, etc).
Milestone
4.12.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Mar 4, 2019

Type of report

Task

Provide description of the task

The table plugin doesn't have any tests covering headers manipulation (see #1460 (review)). It would be good to add such test so we can prevent bugs like #1397 or #2881.
@f1ames f1ames added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:table The plugin which probably causes the issue. labels Mar 4, 2019
@Dumluregn Dumluregn self-assigned this Mar 11, 2019
@mlewand mlewand added changelog:skip A changelog entry should not be added for a given issue. target:minor Any docs related issue that can be merged into a master or major branch. labels Mar 15, 2019
@Dumluregn Dumluregn mentioned this issue Mar 15, 2019
Merged
1 task
@Dumluregn Dumluregn mentioned this issue Mar 28, 2019
Closed
@f1ames
Copy link
Contributor Author

f1ames commented Apr 25, 2019

Fixed in 3e59d63.

@f1ames f1ames closed this as completed Apr 25, 2019
@f1ames f1ames added this to the 4.11.5 milestone Apr 25, 2019
@f1ames f1ames modified the milestones: 4.11.5, 4.12.0 May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dumluregn Dumluregn

Labels
changelog:skip A changelog entry should not be added for a given issue. good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. plugin:table The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
4.12.0
Development

No branches or pull requests
4 participants
@f1ames @mlewand @jacekbogdanski @Dumluregn