Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Polyfill for Object.keys() doesn't accept non-objects on IE8 #3381

Closed
msamsel opened this issue Sep 4, 2019 · 1 comment · Fixed by #3383
Closed

Polyfill for Object.keys() doesn't accept non-objects on IE8 #3381

msamsel opened this issue Sep 4, 2019 · 1 comment · Fixed by #3383
Assignees
@Comandeer
Labels
browser:ie8 The issue can only be reproduced in the Internet Explorer 8 browser. core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Milestone
4.13.0

Comments

@msamsel
Copy link
Contributor

msamsel commented Sep 4, 2019

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Execute CKEDITOR.tools.object.keys( undefined ) or CKEDITOR.tools.object.keys( null ) on IE8 browser

Expected result

An empty array as it works for other browsers.

Actual result

Throw an error: "Object expected"

Other details

  • Browser: IE8
  • OS: Win7
  • CKEditor version: 4.12.1
  • Installed CKEditor plugins: …
@msamsel msamsel added type:bug A bug. status:confirmed An issue confirmed by the development team. browser:ie8 The issue can only be reproduced in the Internet Explorer 8 browser. labels Sep 4, 2019
@Comandeer
Copy link
Member

It seems that this discrepancy is caused by the difference between Object.keys behaviour in ES5 and ES2015+: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/keys#Notes

@Comandeer Comandeer self-assigned this Sep 5, 2019
@Comandeer Comandeer mentioned this issue Sep 5, 2019
Merged
2 tasks
@f1ames f1ames mentioned this issue Sep 6, 2019
Merged
2 tasks
@f1ames f1ames added this to the 4.13.0 milestone Sep 6, 2019
@f1ames f1ames added core The issue is caused by the editor core code. target:major Any docs related issue that should be merged into a major branch. labels Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
browser:ie8 The issue can only be reproduced in the Internet Explorer 8 browser. core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. target:major Any docs related issue that should be merged into a major branch. type:bug A bug.
Projects
None yet
Milestone
4.13.0
Development

Successfully merging a pull request may close this issue.

Add support for non-object in CKEDITOR.tools.object.keys in IE8 ckeditor/ckeditor4
3 participants
@f1ames @Comandeer @msamsel