Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table row properties dialog #109

Closed
wants to merge 3 commits into from
Closed

Conversation

@Jelle-S
Copy link

Jelle-S commented Jun 27, 2014

This pull request allows users to add classes, id and style attributes to a table row.

@Reinmar

This comment has been minimized.

Copy link
Member

Reinmar commented Mar 16, 2015

Hi,

I'm very sorry for the lack of response. We optimistically assumed that we'll be able to finish your PR and we reported http://dev.ckeditor.com/ticket/12269. But it turned out that we weren't able to work on this since then. We should have replied you with what's missing in the PR instead.

If you're still interested to work on the row properties dialog, which we would also like to see in the core, the most important thing to do are tests. Here you can read about CKEditor testing environment. Another thing is code style issues - you can check it with grunt jscs:all && grunt jshint:all after installing Grunt (we also use git hooks, but we didn't yet document this - see grunt --help).

@mlewand

This comment has been minimized.

Copy link
Member

mlewand commented Mar 8, 2017

Hi, It's been a while since we last heard from you. We're closing this issue for now. Feel free to still provide us requested feedback, so that we can reopen this issue.

@mlewand mlewand closed this Mar 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.