Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved pastefromword to retain cell borders #2219

Merged
merged 51 commits into from
Jun 3, 2019
Merged

Improved pastefromword to retain cell borders #2219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
e46e8bf
Added cell borders support.
jacekbogdanski Jul 11, 2018
9ace59b
Fixed border support for IE.
jacekbogdanski Jul 12, 2018
c4d340e
Parsing points to pixels.
jacekbogdanski Jul 13, 2018
68b74ab
Parsing points to pixels.
jacekbogdanski Jul 13, 2018
74b2cc5
Added manual test.
jacekbogdanski Sep 4, 2018
c071498
Updated manual test.
jacekbogdanski Nov 16, 2018
ac0d787
Comment refactoring.
jacekbogdanski Nov 19, 2018
6b09d1c
Added width and height to table cells.
jacekbogdanski Nov 19, 2018
129a381
Added border styles helpers.
jacekbogdanski Nov 26, 2018
59663e3
Refactored code to use tool helpers.
jacekbogdanski Dec 1, 2018
23e042c
Updated allowed content to accept styles stack.
jacekbogdanski Dec 1, 2018
72511f8
Updated point to px regex.
jacekbogdanski Dec 1, 2018
b034211
Updated manual test, added example Exel file.
jacekbogdanski Dec 1, 2018
3e81f84
Removed unecessary ACF entries, content should depend on used plugin.
jacekbogdanski Dec 1, 2018
86cf769
Updated manual test to reflect IE8 and Safari upstreams.
jacekbogdanski Dec 1, 2018
7059f25
Added tests for style.parse.shorthand.
jacekbogdanski Dec 2, 2018
74e1cc1
Updated border helpers docs.
jacekbogdanski Dec 2, 2018
775182a
Added tests for border helpers.
jacekbogdanski Dec 2, 2018
0f19ff8
Removed attributes from rows, so they don't leak unecessary to cells.
jacekbogdanski Dec 2, 2018
8571517
Added generic test for chrome.
jacekbogdanski Dec 2, 2018
4000e25
Updated setStyle style removal condition.
jacekbogdanski Dec 20, 2018
b91043c
Renamed shorthand into sideShorthand.
jacekbogdanski Dec 20, 2018
e25cc2d
Moved ACF rules into table plugin.
jacekbogdanski Jan 10, 2019
c91e204
Renaming.
jacekbogdanski Jan 10, 2019
9d66ffa
Replaced raw object with BorderStyle.
jacekbogdanski Jan 10, 2019
148f419
Updated docs.
jacekbogdanski Jan 10, 2019
7cf9de1
Moved border functions to borderStyle object.
jacekbogdanski Jan 18, 2019
7e6854c
Corrected docs with new border namespace.
jacekbogdanski Jan 20, 2019
62da938
Updated borderStyle reference.
jacekbogdanski Jan 20, 2019
8f37434
Inlined convert to px regex.
jacekbogdanski Jan 20, 2019
95795bf
Fixed callback return docs.
jacekbogdanski Jan 20, 2019
c7ea003
Function name renaming.
jacekbogdanski Feb 12, 2019
f576eec
Improved returned type.
jacekbogdanski Feb 12, 2019
b498a00
Linked external docs using markdown syntax.
jacekbogdanski Feb 12, 2019
bee3616
Deprecated parse.border method.
jacekbogdanski Feb 12, 2019
d4f5146
Docs improvement.
jacekbogdanski Feb 13, 2019
c689b9d
Updated chrome tests.
jacekbogdanski Feb 27, 2019
574bec3
Added revert keyword.
jacekbogdanski Feb 27, 2019
a35f34b
Remove leftover border styles to avoid conflicts.
jacekbogdanski Feb 27, 2019
a2e799d
Fixed IE11 manual tests.
jacekbogdanski Feb 27, 2019
23fe8ad
Unified background color property.
jacekbogdanski Mar 4, 2019
c1f1107
Removed redundant css rules.
jacekbogdanski Mar 4, 2019
230d92e
Border side property value is preferred over more more general styles.
jacekbogdanski Mar 4, 2019
876890d
Corrected tests for the recent changes.
jacekbogdanski Mar 4, 2019
3f8ec20
Test assertion refactoring.
jacekbogdanski Mar 4, 2019
e0d4959
Added missing Border tests.
jacekbogdanski Mar 4, 2019
c7411d5
Improved docs.
jacekbogdanski Mar 4, 2019
d82c748
Added generic table test for word and excel.
jacekbogdanski Mar 4, 2019
4196177
Added changelog entry for #2923, updated tests.
jacekbogdanski Mar 4, 2019
b065290
Added missing changelog entries.
jacekbogdanski Mar 4, 2019
f055da7
Removed leftovers.
jacekbogdanski Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,14 @@ New Features:

* [#2598](https://github.com/ckeditor/ckeditor-dev/issues/2598): [Page Break](https://ckeditor.com/cke4/addon/pagebreak) feature support for [Paste from Word](https://ckeditor.com/cke4/addon/pastefromword) plugin.
* [#2048](https://github.com/ckeditor/ckeditor-dev/issues/2048): [Enhanced Image](https://ckeditor.com/cke4/addon/image2) added config option [CKEDITOR.config.image2_maxSize](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_config.html#cfg-image2_maxSize) that allows setting a maximum size that image can be resized to with resizer.
* [#1490](https://github.com/ckeditor/ckeditor-dev/issues/1490): Improved [Paste from Word](https://ckeditor.com/cke4/addon/pastefromword) plugin to retain table cell borders.

Fixed Issues:

* [#2672](https://github.com/ckeditor/ckeditor-dev/issues/2672): Fixed: When resizing [Enhanced Image](https://ckeditor.com/cke4/addon/image2) to minimum size with a resizer the image dialog doesn't show actual values.
* [#1478](https://github.com/ckeditor/ckeditor-dev/issues/1478): Fixed: Custom colors added to [Color Button](https://ckeditor.com/cke4/addon/colorbutton) via [`config.colorButton_colors`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_config.html#cfg-colorButton_colors) in form label/code don't work correctly.
* [#1469](https://github.com/ckeditor/ckeditor-dev/issues/1469): Fixed: Trying to get data from nested editable inside freshly pasted widget throws an error.
* [#2923](https://github.com/ckeditor/ckeditor-dev/issues/2923): Fixed: CSS `windowtext` color is not correctly recognized by [`CKEDITOR.tools.style.parse`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_tools_style_parse.html) functions.

API Changes:

Expand All @@ -25,10 +27,12 @@ API Changes:
* [#2698](https://github.com/ckeditor/ckeditor-dev/issues/2698): Added the [`CKEDITOR.htmlParser.element.findOne`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_htmlParser_element.html#method-findOne) method.
* [#2935](https://github.com/ckeditor/ckeditor-dev/issues/2935): Introduced [`CKEDITOR.config.pasteFromWord_keepZeroMargins`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_config.html#cfg-pasteFromWord_keepZeroMargins) config option, that allows keeping any `margin-*: 0` style that would be otherwise removed when pasting content with [Paste from Word](https://ckeditor.com/cke4/addon/pastefromword) plugin.
* [#2962](https://github.com/ckeditor/ckeditor-dev/issues/2962): Added the [`CKEDITOR.tools.promise`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_tools_promise.html) class.
* [#2924](https://github.com/ckeditor/ckeditor-dev/issues/2924): Added the [`CKEDITOR.tools.style.border`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_tools_style_border.html) object wrapping CSS border style helpers under single type.

Other Changes:

* [#2741](https://github.com/ckeditor/ckeditor-dev/issues/2721): Replaced deprecated `arguments.callee` calls with named function expressions.
* [#2924](https://github.com/ckeditor/ckeditor-dev/issues/2924): Marked [`CKEDITOR.tools.style.parse.border`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_tools_style_border.html) as deprecated in favor of [`CKEDITOR.tools.style.border.fromCssRule`](https://ckeditor.com/docs/ckeditor4/latest/api/CKEDITOR_tools_style_border.html#static-method-fromCssRule) function.

## CKEditor 4.11.4

Expand Down
Loading