Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable PfLO in IE 11 #3852

Merged
merged 4 commits into from Feb 13, 2020
Merged

Disable PfLO in IE 11 #3852

merged 4 commits into from Feb 13, 2020

Conversation

@Comandeer
Copy link
Member

Comandeer commented Feb 11, 2020

What is the purpose of this pull request?

Bug fix

Does your PR contain necessary tests?

All patches which change the editor code must include tests. You can always read more
on PR testing,
how to set the testing environment and
how to create tests
in the official CKEditor documentation.

This PR contains

  • Unit tests
  • Manual tests

Did you follow CKEditor 4 code style guide?

Your code should follow guidelines from CKEditor 4 code style guide which helps keep the entire codebase consistent.

  • PR is consistent with code style guide

What is the proposed changelog entry for this pull request?

None

What changes did you make?

This PR disables PfLO and its tests in IE. See ckeditor/ckeditor4-presets#30 (review) for more details.

@Comandeer Comandeer mentioned this pull request Feb 11, 2020
@f1ames f1ames self-requested a review Feb 12, 2020
@f1ames f1ames self-assigned this Feb 12, 2020
Copy link
Member

f1ames left a comment

The CI is red and some (same I think) tests fails locally too:

I think the leftover fixtures (for Safari, IE11s) are still usedin unit tests and breaks them.

@Comandeer Comandeer self-assigned this Feb 12, 2020
Comandeer added 4 commits Feb 11, 2020
This reverts commit 6565b99, reversing
changes made to e6c0015.
@Comandeer Comandeer force-pushed the pflo-ie branch from c54d010 to 797eecd Feb 12, 2020
@Comandeer

This comment has been minimized.

Copy link
Member Author

Comandeer commented Feb 12, 2020

Removed unnecessary fixtures.

@Comandeer Comandeer requested a review from f1ames Feb 12, 2020
@f1ames f1ames self-assigned this Feb 13, 2020
@f1ames
f1ames approved these changes Feb 13, 2020
Copy link
Member

f1ames left a comment

👍

@f1ames f1ames merged commit e4199cf into major Feb 13, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@CKEditorBot CKEditorBot deleted the pflo-ie branch Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.