Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in inline code snippet #994

Merged
merged 1 commit into from Oct 4, 2017
Merged

Fix typo in inline code snippet #994

merged 1 commit into from Oct 4, 2017

Conversation

benjy
Copy link
Contributor

@benjy benjy commented Oct 3, 2017

What is the purpose of this pull request?

Typo fix

@msamsel
Copy link
Contributor

msamsel commented Oct 3, 2017

Hi @benjy,
thank you very much for your contribution. We still need for your CLA signature to have possibility to merge your changes with CKEditor. :) I hope it won't be a problem in this case.

@msamsel msamsel assigned benjy and unassigned msamsel Oct 3, 2017
@benjy
Copy link
Contributor Author

benjy commented Oct 3, 2017

Sure, are you emailing the details?

@mlewand
Copy link
Contributor

mlewand commented Oct 3, 2017

@benjy CLA could not be sent because you have masked email. Please either:

  • Share your email address through our contact form (use inquire type "other" and link to this PR).
  • Unmask your email.

Choose whatever works better for you. Sorry for so much hassle for such a small change... 😉

@benjy
Copy link
Contributor Author

benjy commented Oct 3, 2017

I've signed the document, it was a little convoluted, a bit of political correctness gone mad I think!

@msamsel msamsel merged commit 8a96a9a into ckeditor:major Oct 4, 2017
@mlewand
Copy link
Contributor

mlewand commented Oct 4, 2017

Thanks for the contribution @benjy. Sorry for the formal part, but we simply need them for accepting any work. And clearly our CLA system needs a better handling for masked mails, as it's not uncommon to use it (I'm using it myself 😉).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants