A really nice fellow.
' ); } ); - it( 'should show and update json data preview', async () => { + it( 'should show and update json data preview', async() => { expect( await page.getFormDataPreview() ) .toEqual( '{"name":"John","surname":"Doe","description":"A really nice fellow.
"}' ); diff --git a/e2e/src/app.po.ts b/e2e/src/app.po.ts index 93275f4..ea15e41 100644 --- a/e2e/src/app.po.ts +++ b/e2e/src/app.po.ts @@ -1,49 +1,49 @@ import { browser, by, element, promise } from 'protractor'; export class AppPage { - navigateTo( url = '' ) { + public navigateTo( url = '' ) { return browser.get( '/' + url ); } - getHeaderContent() { + public getHeaderContent() { return element( by.css( 'app-root h1' ) ).getText(); } - getEditorContent(): promise.PromiseGetting used to an entirely different culture can be challenging. + `
Getting used to an entirely different culture can be challenging. While it’s also nice to learn about cultures online or from books, nothing comes close to experiencing cultural diversity in person. You learn to appreciate each and every single one of the differences while you become more culturally fluid.
`; public componentEvents: string[] = []; - toggleDisableEditors() { + public toggleDisableEditors() { this.isDisabled = !this.isDisabled; } - onReady( editor: CKEditor5.Editor ): void { + public onReady() { this.componentEvents.push( 'The editor is ready.' ); } - onChange( event: ChangeEvent ): void { + public onChange() { this.componentEvents.push( 'Editor model changed.' ); } - onFocus( event: FocusEvent ): void { + public onFocus() { this.componentEvents.push( 'Focused the editing view.' ); } - onBlur( event: BlurEvent ): void { + public onBlur() { this.componentEvents.push( 'Blurred the editing view.' ); } } diff --git a/src/ckeditor/ckeditor.component.spec.ts b/src/ckeditor/ckeditor.component.spec.ts index 7703cdd..77fc424 100644 --- a/src/ckeditor/ckeditor.component.spec.ts +++ b/src/ckeditor/ckeditor.component.spec.ts @@ -128,27 +128,27 @@ describe( 'CKEditorComponent', () => { it( 'should not be set using `editor.setData()` during the initialization step', () => { class EventEmitter { - on() {} + public on() {} } class EditorMock { - model = { + public model = { document: new EventEmitter() }; - editing = { + public editing = { view: { document: new EventEmitter() } }; - setData = createSpy(); + public setData = createSpy(); - static create() { + public static create() { return Promise.resolve( new this() ); } - destroy() {} + public destroy() {} } function createSpy() { @@ -294,7 +294,7 @@ describe( 'CKEditorComponent', () => { let component: CKEditorComponent; class EditorThatThrowsErrorDuringInitialization { - static create() { + public static create() { return Promise.resolve().then( () => { return Promise.reject( new Error() ); } ); diff --git a/src/ckeditor/ckeditor.component.ts b/src/ckeditor/ckeditor.component.ts index d19656a..4e3ca3c 100644 --- a/src/ckeditor/ckeditor.component.ts +++ b/src/ckeditor/ckeditor.component.ts @@ -29,6 +29,7 @@ import { CKEditor5 } from './ckeditor'; providers: [ { provide: NG_VALUE_ACCESSOR, + // eslint-disable-next-line @typescript-eslint/no-use-before-define useExisting: forwardRef( () => CKEditorComponent ), multi: true, } @@ -44,38 +45,38 @@ export class CKEditorComponent implements AfterViewInit, OnDestroy, ControlValue * The constructor of the editor to be used for the instance of the component. * It can be e.g. the `ClassicEditorBuild`, `InlineEditorBuild` or some custom editor. */ - @Input() editor?: CKEditor5.EditorConstructor; + @Input() public editor?: CKEditor5.EditorConstructor; /** * The configuration of the editor. * See https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editorconfig-EditorConfig.html * to learn more. */ - @Input() config: CKEditor5.Config = {}; + @Input() public config: CKEditor5.Config = {}; /** * The initial data of the editor. Useful when not using the ngModel. * See https://angular.io/api/forms/NgModel to learn more. */ - @Input() data = ''; + @Input() public data = ''; /** * Tag name of the editor component. * * The default tag is 'div'. */ - @Input() tagName = 'div'; + @Input() public tagName = 'div'; /** * When set `true`, the editor becomes read-only. * See https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editor-Editor.html#member-isReadOnly * to learn more. */ - @Input() set disabled( isDisabled: boolean ) { + @Input() public set disabled( isDisabled: boolean ) { this.setDisabledState( isDisabled ); } - get disabled() { + public get disabled() { if ( this.editorInstance ) { return this.editorInstance.isReadOnly; } @@ -88,28 +89,28 @@ export class CKEditorComponent implements AfterViewInit, OnDestroy, ControlValue * https://ckeditor.com/docs/ckeditor5/latest/api/module_core_editor_editor-Editor.html#event-ready * event. */ - @Output() ready = new EventEmitter