Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error thrown when creating second style #13

Closed
Reinmar opened this Issue Nov 8, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@Reinmar
Copy link
Member

commented Nov 8, 2016

I got the error while typing this text:

image

@szymonkups

This comment has been minimized.

Copy link
Contributor

commented Nov 9, 2016

I took a while to debug this. It looks like it will be a renderer issue.
When first style is applied, view looks something like this:

<p>You can <strong>bold</strong>[]</p>

And inline filler is applied in the second text node (after </strong>).
When second attribute is applied:

<p>You can <strong>bold</strong> or <em>italicise</em></p>

Rendering occurs. At the begining, rendering checks if selection is in inline filler: https://github.com/ckeditor/ckeditor5-engine/blob/ceb51fa/src/view/renderer.js#L183

Renderer._isSelectionInInlineFiller is trying to translate view selection position into DOM position, (by using DomConverter.viewPositionToDom), but this is impossible because:

  • in the view we've already changed *italicize* to <em>italicize</em>,
  • there is no DOM corresponding element as it will be created later on during this rendering.

@Reinmar Reinmar referenced this issue Nov 9, 2016

Merged

T/675 #676

@Reinmar

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2016

There's a chance that this issue will be fixed in ckeditor/ckeditor5-engine#676.

@Reinmar

This comment has been minimized.

Copy link
Member Author

commented Nov 16, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.