New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundling a different language #11

Closed
Reinmar opened this Issue Apr 27, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@Reinmar
Copy link
Member

Reinmar commented Apr 27, 2017

By default, English strings are used in the bundles. We can make it configurable by specifying the language in build-config.js and reading it from Webpack config files.

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Aug 10, 2017

@pomek

This comment has been minimized.

Copy link
Member

pomek commented Aug 10, 2017

A lot of translation' files are missing:

image

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Aug 10, 2017

Maybe true right now since we haven't regenerated them for a long time. I'll do it today.

@pomek

This comment has been minimized.

Copy link
Member

pomek commented Aug 10, 2017

But it works :D

image

@pomek

This comment has been minimized.

Copy link
Member

pomek commented Aug 10, 2017

The question is – should we add the CKEditorWebpackPlugin every time or only if the specified language is other than en?

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Aug 10, 2017

I think all the time. To KISS and to make sure that the translations (even en->en) are used.

@Reinmar

This comment has been minimized.

Copy link
Member Author

Reinmar commented Aug 10, 2017

I can't upload the translations for now: ckeditor/ckeditor5-dev#249.

@Reinmar Reinmar closed this in #14 Aug 15, 2017

Reinmar added a commit that referenced this issue Aug 15, 2017

Merge pull request #14 from ckeditor/t/11
Feature: Support for building the editor in another language than `en`. Closes #11.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment