Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Resolve circular dependencies #375
Below post assumes that #480 is done
(here's a link to the sketch if you want to play with it: https://sketchboard.me/Tz1FbT5aiDkv)
This is a sketch that I've made that shows up imports between classes in model. I hope I haven't missed anything. View is very similar. In model there is also
Here are some conclusions that can be drawn from sketch:
For now we got rid off circular deps in model tree structure and it's API. The question is whether I should work more to make this graph even more clear or is it okay right now? TBH it will be hard to make it any better and I fear that many solutions would just come down to hide the dependencies in new classes/tools.
I've updated the scheme to make it more UML correct and clean:
(still available at https://sketchboard.me/Tz1FbT5aiDkv)
I've added relations if a class A is a property in class B but is not created by it and does not compose class B. It mostly shows "parent-children" association. It's denoted by arrow with black full point. You can see how
I've also changed some arrows. Now you can see when class A composes class B (i.e.
Below is the same scheme without "property" relationships: